Multi Account Mixed Observability Observability Accelerator #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elamaran11
requested changes
Oct 5, 2023
There was a problem hiding this comment.
@iamprakkie AWSome work. some minor feedback. Also mkdocs.yml file update and readMe update for list of patterns is missing.
lib/multi-acc-new-eks-mixed-observability-pattern/grafana-operator-index.ts
Outdated
Show resolved
Hide resolved
elamaran11
requested changes
Oct 6, 2023
elamaran11
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
@iamprakkie Finally. Looks AWSome. This is outstanding work. So happy it got to Amazing shape. Thankyou for the hardwork. LGTM
elamaran11
requested changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Multi Account Mixed Observability Observability Accelerator pattern.
Change log
Monitoring Environment now has an EKS cluster built using
ObservabilityBuilderwith Grafana Operator and External Secrets usingGrafanaOperatorConstruct. Uses ArgoCDAddOn for GitOps.Sample apps for prod accounts will be taken from https://github.com/iamprakkie/aws-observability-accelerator.git instead of https://github.com/aws-samples/eks-blueprints-workloads.git. Final change will be updated to aws-observability/aws-observability-accelerator.
Identity, datasources, dashboards for Grafana Operator are from https://github.com/iamprakkie/aws-observability-accelerator.git. Final change will be updated to aws-observability/aws-observability-accelerator. Grafana Dashboard URLs taken from cdk.json.
Documentation covers all steps required to deploy the pattern.
Trust entities for AMP role and CW role now uses WorkspaceIamRole as principal.
github-tokenandgithub-ssh-keyare stored in AWS SecretsManager inpipelineandmonitoringaccount. Rest all are moved to SSM Securestring parameter.gitOwner will be picked up from SSM parameter
/cdk-accelerator/pipeline-git-info.Clean up script takes care of deleting stack resources and stack which are not covered with pattern destroy option.
Can be used for multi-account with multiple-regions too.
Work in progress
Architecture diagram.
sample-apps and grafana-operator-app git URLs to point out to
aws-observability/aws-observability-accelerator.